Fallback to zero value for initiatedID in ExternalExecutionInfoFields struct #4720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 46ad55fc-ab6d-47b3-9ef9-a0015e9c379f
💛 - Coveralls |
vytautas-karpavicius
approved these changes
Feb 1, 2022
Shaddoll
added a commit
to Shaddoll/cadence
that referenced
this pull request
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Do not panic if initiatedID is missing when mapping ExternalExecutionInfoFields. Instead fallback to zero values.
Why?
To address #4721
Originally both initiatedID and execution are empty, but starting from #4612
execution is not empty for cancelliing child workflows
How did you test it?
unit test
Potential risks
Release notes
Documentation Changes