Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Hostinfo with identity and port map #4706

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

mantas-sidlauskas
Copy link
Contributor

What changed?
Adding additional fields to membership.Hostinfo struct.

Why?
Currently, IP:port tuple is kept in the addr field, which is used for both: identity and addressing needs.

Added fields will be used to provide more information about peer details in a ring.
This is needed to support multi-transport RPC topologies or RPC transport to transport migrations.

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build dc61b7f0-217f-469d-9ee5-fff8ce1d9a13

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • 86 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.04%) to 56.939%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/membership/hashring.go 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
common/membership/hashring.go 1 76.83%
common/persistence/executionManager.go 2 76.94%
common/persistence/statsComputer.go 2 96.43%
common/task/fifoTaskScheduler.go 2 87.63%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/execution/mutable_state_builder.go 2 69.66%
service/history/queue/transfer_queue_processor.go 2 56.86%
common/persistence/dataManagerInterfaces.go 3 58.49%
service/history/task/fetcher.go 3 86.67%
common/persistence/sql/sqlExecutionStore.go 5 62.91%
Totals Coverage Status
Change from base Build 37cef24f-8eb2-4aa0-b491-dccd706aa5cd: -0.04%
Covered Lines: 82918
Relevant Lines: 145625

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants