Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate parentClosePolicy task for x-cluster child #4682

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Dec 14, 2021

What changed?

  • Instead of always signaling system workflow for applying parent close policy for x-cluster child, generate x-cluster parent close policy task now that the bugs in that task implementation have been fixed.

Why?

  • Revert temp workaround for x-cluster parent close policy task bug

How did you test it?

  • Unit test.

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1cfb54f8-b603-4023-b82f-41d25db443e8

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • 89 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.05%) to 56.941%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 78.6%
client/history/client.go 2 39.33%
client/history/metricClient.go 2 46.37%
common/persistence/executionManager.go 2 76.57%
common/persistence/statsComputer.go 2 96.43%
common/task/fifoTaskScheduler.go 2 85.57%
service/history/handler.go 2 48.56%
service/history/queue/transfer_queue_processor.go 2 57.24%
service/matching/matcher.go 3 91.06%
service/frontend/workflowHandler.go 4 59.4%
Totals Coverage Status
Change from base Build 914edd1d-bdb8-44e1-abbb-61607e268479: -0.05%
Covered Lines: 82836
Relevant Lines: 145478

💛 - Coveralls

@yycptt yycptt merged commit b7d2c77 into uber:master Dec 14, 2021
@yycptt yycptt deleted the revert-parent-close-policy-signal branch December 14, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants