Switch system worker to gRPC #4679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vytautas-karpavicius
force-pushed
the
public-client-grpc
branch
from
7f6a421
to
7b21152
Compare
vytautas-karpavicius
force-pushed
the
public-client-grpc
branch
from
7b21152
to
99842a6
Compare
mantas-sidlauskas
approved these changes
Dec 13, 2021
common/rpc/outbounds.go
Outdated
| @@ -81,6 +81,7 @@ func (b multiOutbounds) Build(grpc *grpc.Transport, tchannel *tchannel.Transport | |||
|
|
|||
| type publicClientOutbound struct { | |||
| address string | |||
| isGrpc bool | |||
|
|
||
| builder, err = newPublicClientOutbound(makeConfig("localhost:1234", true, "invalid")) | ||
| builder, err = newPublicClientOutbound(makeConfig("localhost:1234", "tchannel", true, "invalid")) | ||
| require.EqualError(t, err, "create AuthProvider: invalid private key path invalid") | ||
|
|
There was a problem hiding this comment.
Nit: As you added require.True(t, builder.isGrpc), maybe add False check here?
Suggested change
| require.False(t, builder.isGrpc) |
akijakya
added a commit
to banzaicloud/banzai-charts
that referenced
this pull request
Nov 14, 2022
As per this PR: uber/cadence#4679
3 tasks
akijakya
added a commit
to banzaicloud/banzai-charts
that referenced
this pull request
Nov 17, 2022
As per this PR: uber/cadence#4679
akijakya
added a commit
to banzaicloud/banzai-charts
that referenced
this pull request
Nov 17, 2022
As per this PR: uber/cadence#4679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Switch
PublicClientused mainly by Worker role to communicate in gRPCAdditional
transportconfig was introduced underpublicClientto allow overriding transport back tchannel which otherwise would default to grpc.Why?
Final bits of gRPC migration on server side.
How did you test it?
Updated integration tests.
Locally started cadence canary. Issues batch terminate command which would start batch workflow on system worker.
Potential risks
Release notes
Documentation Changes