Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs for ID length violation checkers #4655

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

Shaddoll
Copy link
Contributor

What changed?
Add logs for ID length violation checkers

Why?
Improve observability to make us able to guide our cadence users to reduce the ID length

How did you test it?
existing test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Nov 22, 2021

Pull Request Test Coverage Report for Build d6a5d2f0-2a45-42cb-8736-e7699dc20618

  • 175 of 193 (90.67%) changed or added relevant lines in 5 files are covered.
  • 101 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.005%) to 56.911%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/util.go 3 9 33.33%
service/frontend/workflowHandler.go 88 100 88.0%
Files with Coverage Reduction New Missed Lines %
client/history/client.go 2 39.63%
client/history/metricClient.go 2 45.94%
service/history/handler.go 2 48.42%
common/cache/lru.go 3 90.73%
service/history/queue/timer_gate.go 3 95.83%
common/persistence/serialization/parser.go 4 65.41%
common/persistence/serialization/thrift_decoder.go 4 61.22%
common/task/fifoTaskScheduler.go 4 83.51%
service/frontend/workflowHandler.go 4 59.28%
service/history/historyEngine.go 9 70.83%
Totals Coverage Status
Change from base Build 9caa1c3e-81ea-4050-9db5-01b45b9ae66d: -0.005%
Covered Lines: 82444
Relevant Lines: 144864

💛 - Coveralls

"github.com/uber/ringpop-go"
"github.com/uber/ringpop-go/swim"
tcg "github.com/uber/tchannel-go"
"go.uber.org/yarpc/transport/tchannel"

"github.com/uber/cadence/common/service"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: empty line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's added by linter

@Shaddoll Shaddoll merged commit 3b36196 into uber:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants