Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin tool to decode any thrift binary into JOSN #4634

Merged
merged 5 commits into from
Nov 16, 2021

Conversation

longquanzheng
Copy link
Collaborator

@longquanzheng longquanzheng commented Nov 12, 2021

What changed?
Add admin tool to decode any thrift binary into JOSN

Why?

How did you test it?
Tested locally:

(qlong-admin-cli-thrift) $./cadence adm db decode_thrift -i 590a000a00000000000000820a00140000001a284aac6608001e000000170a002300000000000004d20c012c0b001400000019736f6d652072616e646f6d2074617267657420646f6d61696e0c001e0b000a0000001e736f6d652072616e646f6d2074617267657420776f726b666c6f772049440b001400000019736f6d652072616e646f6d207461726765742072756e204944000b002800000013736f6d652072616e646f6d20636f6e74726f6c020032010000
=======Decode into type shared.HistoryEvent ========
{EventId:130, Timestamp:112345132134, EventType:RequestCancelExternalWorkflowExecutionInitiated, Version:1234, RequestCancelExternalWorkflowExecutionInitiatedEventAttributes:{Domain:some random target domain, WorkflowExecution:{WorkflowId:some random target workflow ID, RunId:some random target run ID}, Control:[some random control], ChildWorkflowOnly:true}}




Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Nov 12, 2021

Pull Request Test Coverage Report for Build 020f0162-8860-42ec-a438-551126cdbc87

  • 0 of 28 (0.0%) changed or added relevant lines in 2 files are covered.
  • 94 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.004%) to 56.856%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/cli/admin.go 0 3 0.0%
tools/cli/adminDBCleanCommand.go 0 25 0.0%
Files with Coverage Reduction New Missed Lines %
client/history/client.go 2 39.63%
client/history/metricClient.go 2 45.94%
common/membership/ringpop_config.go 2 81.58%
common/task/fifoTaskScheduler.go 2 87.63%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
common/types/mapper/thrift/shared.go 2 63.43%
service/history/handler.go 2 48.42%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 55.49%
service/frontend/workflowHandler.go 4 58.61%
service/history/task/redispatcher.go 4 89.67%
Totals Coverage Status
Change from base Build 497c5879-89a5-4d38-8392-89e82f1e16e6: -0.004%
Covered Lines: 82290
Relevant Lines: 144733

💛 - Coveralls

@longquanzheng longquanzheng changed the title Add admin tool to decode any thrift binary into JOSN [WIP]Add admin tool to decode any thrift binary into JOSN Nov 12, 2021
@longquanzheng longquanzheng changed the title [WIP]Add admin tool to decode any thrift binary into JOSN Add admin tool to decode any thrift binary into JOSN Nov 16, 2021
@longquanzheng longquanzheng enabled auto-merge (squash) November 16, 2021 21:47
@longquanzheng longquanzheng merged commit 9d40c45 into master Nov 16, 2021
@longquanzheng longquanzheng deleted the qlong-admin-cli-thrift branch November 16, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants