Use generated proto types from cadence-idl repo #4630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4992bcea-e6dc-4a22-8e90-806b4ce41a55
💛 - Coveralls |
vytautas-karpavicius
force-pushed
the
common-proto-api
branch
from
f53ca6c
to
239c9cf
Compare
vytautas-karpavicius
force-pushed
the
common-proto-api
branch
from
239c9cf
to
c9c578d
Compare
mantas-sidlauskas
approved these changes
Nov 15, 2021
| @@ -225,7 +226,7 @@ $(THRIFT_GEN): $(THRIFT_FILES) $(BIN)/thriftrw $(BIN)/thriftrw-plugin-yarpc | $( | |||
| PROTO_ROOT := proto | |||
| # output location is defined by `option go_package` in the proto files, all must stay in sync with this | |||
| PROTO_OUT := .gen/proto | |||
There was a problem hiding this comment.
is this still relevant?
There was a problem hiding this comment.
Yes, since we still generate all internal types here. Those that are used for history/matching services.
Only public API types were moved to cadence-idl repo, internal types stays here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
go get github.com/uber/cadence-idlgithub.com/uber/cadence/.gen/proto/api/v1withgithub.com/uber/cadence-idl/go/proto/api/v1everywhereWhy?
Public API proto types are generated on cadence-idl repo (uber/cadence-idl#94) so that they could be shared between client/server. Otherwise it results in duplicated type registrations when using both.
How did you test it?
Potential risks
Release notes
Documentation Changes