Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support partial retries for ApplyParentPolicy #4610

Merged
merged 11 commits into from
Dec 1, 2021

Conversation

demirkayaender
Copy link
Contributor

@demirkayaender demirkayaender commented Oct 30, 2021

What changed?
Before this change any failure in applyParentPolicy operation would lead to a full retry where we retry even the successful policy applications. With this change we are only going to retry the failed ones.

Depends on uber/cadence-idl#95

Why?
So we can save resources and operate more efficiently.

How did you test it?
Unit tests.

Potential risks

Release notes

Documentation Changes

@demirkayaender demirkayaender requested review from yycptt and a team October 30, 2021 00:38
@coveralls
Copy link

coveralls commented Oct 30, 2021

Pull Request Test Coverage Report for Build 0cdd859d-6a09-4ccb-8876-55b22215105e

  • 141 of 296 (47.64%) changed or added relevant lines in 6 files are covered.
  • 83 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.04%) to 56.91%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/task/cross_cluster_source_task_executor.go 45 52 86.54%
common/types/mapper/proto/shared.go 54 62 87.1%
service/history/task/cross_cluster_target_task_executor.go 42 53 79.25%
service/history/task/cross_cluster_task.go 0 12 0.0%
common/types/shared.go 0 37 0.0%
common/types/mapper/thrift/shared.go 0 80 0.0%
Files with Coverage Reduction New Missed Lines %
common/persistence/executionManager.go 2 76.57%
common/persistence/statsComputer.go 2 96.43%
common/types/mapper/thrift/shared.go 2 63.17%
service/history/execution/mutable_state_builder.go 2 69.66%
service/history/queue/transfer_queue_processor.go 2 57.24%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 55.49%
service/history/task/cross_cluster_source_task_executor.go 3 72.59%
common/persistence/sql/sqlExecutionStore.go 5 62.69%
common/task/fifoTaskScheduler.go 5 84.54%
service/history/shard/context.go 9 66.22%
Totals Coverage Status
Change from base Build 22f39ea4-cb01-4509-8e2e-f99335ccae48: -0.04%
Covered Lines: 82724
Relevant Lines: 145360

💛 - Coveralls

@demirkayaender demirkayaender force-pushed the partialApplyParent branch 2 times, most recently from 73cabb4 to d722393 Compare November 16, 2021 00:09
common/types/mapper/proto/shared.go Show resolved Hide resolved
common/types/mapper/thrift/shared.go Show resolved Hide resolved
common/types/shared.go Outdated Show resolved Hide resolved
common/types/mapper/thrift/shared.go Outdated Show resolved Hide resolved
common/types/mapper/thrift/shared.go Outdated Show resolved Hide resolved
common/types/mapper/thrift/shared.go Outdated Show resolved Hide resolved
service/history/task/cross_cluster_target_task_executor.go Outdated Show resolved Hide resolved
service/history/task/cross_cluster_source_task_executor.go Outdated Show resolved Hide resolved
service/history/task/cross_cluster_target_task_executor.go Outdated Show resolved Hide resolved
Copy link
Contributor

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Mostly nit/non-blocking comments

common/types/shared.go Outdated Show resolved Hide resolved
@demirkayaender demirkayaender merged commit b730353 into uber:master Dec 1, 2021
@demirkayaender demirkayaender deleted the partialApplyParent branch December 1, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants