-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support partial retries for ApplyParentPolicy #4610
Merged
demirkayaender
merged 11 commits into
uber:master
from
demirkayaender:partialApplyParent
Dec 1, 2021
Merged
Support partial retries for ApplyParentPolicy #4610
demirkayaender
merged 11 commits into
uber:master
from
demirkayaender:partialApplyParent
Dec 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Nov 8, 2021
demirkayaender
force-pushed
the
partialApplyParent
branch
2 times, most recently
from
November 16, 2021 00:09
73cabb4
to
d722393
Compare
demirkayaender
commented
Nov 16, 2021
demirkayaender
force-pushed
the
partialApplyParent
branch
from
November 17, 2021 20:50
d722393
to
6065d20
Compare
demirkayaender
force-pushed
the
partialApplyParent
branch
2 times, most recently
from
November 29, 2021 21:48
c682865
to
3c60276
Compare
yycptt
reviewed
Nov 30, 2021
yycptt
reviewed
Nov 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Mostly nit/non-blocking comments
yycptt
approved these changes
Nov 30, 2021
demirkayaender
force-pushed
the
partialApplyParent
branch
from
December 1, 2021 15:43
42369eb
to
dc5a0f5
Compare
demirkayaender
force-pushed
the
partialApplyParent
branch
from
December 1, 2021 16:31
dc5a0f5
to
4b6e722
Compare
demirkayaender
force-pushed
the
partialApplyParent
branch
from
December 1, 2021 16:45
4b6e722
to
0ae26a8
Compare
yycptt
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Before this change any failure in applyParentPolicy operation would lead to a full retry where we retry even the successful policy applications. With this change we are only going to retry the failed ones.
Depends on uber/cadence-idl#95
Why?
So we can save resources and operate more efficiently.
How did you test it?
Unit tests.
Potential risks
Release notes
Documentation Changes