Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use streaming implementation of thriftrw encoder/decoder #4568

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

Shaddoll
Copy link
Contributor

@Shaddoll Shaddoll commented Oct 13, 2021

What changed?
Use streaming implementation of thriftrw encoder/decoder

Why?
The streaming implementation has better performance according to thriftrw/thriftrw-go#535

How did you test it?
bench tests & existing tests

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll changed the title [WIP] Use streaming implementation of thriftrw encoder/decoder Use streaming implementation of thriftrw encoder/decoder Nov 1, 2021
@Shaddoll Shaddoll requested a review from a team November 1, 2021 16:48
@coveralls
Copy link

coveralls commented Nov 1, 2021

Pull Request Test Coverage Report for Build 75a227dd-c3d5-4b96-a459-02744c1dbdea

  • 15 of 15 (100.0%) changed or added relevant lines in 3 files are covered.
  • 85 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 56.874%

Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 79.5%
common/task/fifoTaskScheduler.go 2 84.54%
service/history/execution/mutable_state_builder.go 2 69.66%
service/history/queue/timer_queue_processor.go 2 58.8%
service/history/queue/transfer_queue_processor.go 2 57.24%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 55.49%
service/history/execution/context.go 6 73.96%
service/history/execution/mutable_state_task_refresher.go 7 71.61%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 21 76.93%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 39 82.59%
Totals Coverage Status
Change from base Build 296dff3b-ac49-4217-8bf4-0ab25c471884: 0.02%
Covered Lines: 82310
Relevant Lines: 144724

💛 - Coveralls

@demirkayaender
Copy link
Contributor

demirkayaender commented Nov 18, 2021

bench tests & existing tests

Do you have some findings with bench tests about its performance?

Copy link
Contributor

@mkolodezny mkolodezny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Shaddoll
Copy link
Contributor Author

bench tests & existing tests

Do you have some findings with bench tests about its performance?

cpu usage reduced by about 9%

@Shaddoll Shaddoll merged commit 0aa7494 into uber:master Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants