Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping optional tests for optional methods in plugins #4287

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

Shaddoll
Copy link
Contributor

What changed?

  • Allow user to skip GetOrphanTasksTest and ScanHistoryTest

Why?

  • Database supporting TTL doesn't need to implement GetOrphanTasks
  • GetAllHistoryTreeBranches doesn't work for sharded SQL

How did you test it?
existing tests

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll requested a review from a team June 28, 2021 18:34
@Shaddoll Shaddoll merged commit 3cc8c31 into uber:master Jun 28, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 42fb267c-c1d8-4896-bc5d-6e343603e392

  • 0 of 6 (0.0%) changed or added relevant lines in 2 files are covered.
  • 102 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.06%) to 59.958%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/persistence-tests/historyV2PersistenceTest.go 0 3 0.0%
common/persistence/persistence-tests/matchingPersistenceTest.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
service/history/queue/timer_queue_processor_base.go 1 78.6%
common/membership/rpServiceResolver.go 2 73.58%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/task/fetcher.go 2 77.18%
service/matching/taskListManager.go 2 74.72%
service/history/task/transfer_active_task_executor.go 4 69.73%
common/task/fifoTaskScheduler.go 5 82.47%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 14 72.8%
common/persistence/cassandra/cassandraTaskPersistence.go 16 58.02%
common/persistence/cassandra/cassandraPersistence.go 23 50.62%
Totals Coverage Status
Change from base Build 8385cc09-aa2d-433f-9f36-97eb9c957446: -0.06%
Covered Lines: 90255
Relevant Lines: 150530

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants