Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal types and mappers for cross cluster related APIs #4285

Merged
merged 4 commits into from
Jun 25, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Jun 25, 2021

What changed?

  • Add internal types for cross cluster related APIs
  • Add corresponding mappers for thrift and proto definition

Why?

  • For supporting cross-domain/cluster operation

How did you test it?
Unit test

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Jun 25, 2021

Pull Request Test Coverage Report for Build 3e21b51a-03ff-4a26-990d-cd262a953d89

  • 351 of 1071 (32.77%) changed or added relevant lines in 5 files are covered.
  • 89 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.2%) to 59.983%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/types/mapper/proto/shared.go 259 319 81.19%
common/types/shared.go 0 298 0.0%
common/types/mapper/thrift/shared.go 0 362 0.0%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
service/history/queue/transfer_queue_processor_base.go 1 79.59%
client/history/client.go 2 44.35%
client/history/metricClient.go 2 49.43%
common/membership/rpServiceResolver.go 2 73.58%
service/history/handler.go 2 46.67%
service/matching/matcher.go 2 91.46%
common/cache/lru.go 3 90.73%
common/persistence/cassandra/cassandraPersistence.go 3 51.94%
service/frontend/workflowHandler.go 4 58.48%
Totals Coverage Status
Change from base Build f11df966-12d3-44d7-884d-dfc1acad4beb: -0.2%
Covered Lines: 90289
Relevant Lines: 150524

💛 - Coveralls

@yycptt yycptt merged commit 622b13b into uber:master Jun 25, 2021
@yycptt yycptt deleted the cross-cluster-type-mapper branch June 25, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants