Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Cross Cluster Operations in SQL type DBs #4271

Merged
merged 7 commits into from
Jun 16, 2021

Conversation

demirkayaender
Copy link
Contributor

@demirkayaender demirkayaender commented Jun 14, 2021

What changed?
Previously cross cluster support was added to Cassandra (#4237), this change adds it for SQL

Why?
So that we can support x-cluster operations in SQL DBs

How did you test it?

go test -v ./common/persistence/sql/sqlplugin/mysql -testify.m TestCrossClusterTasks
go test -v ./common/persistence/sql/sqlplugin/mysql -testify.m TestGetShard
go test -v ./common/persistence/sql/sqlplugin/mysql -testify.m TestUpdateShard
go test -v ./common/persistence/sql/sqlplugin/mysql -testify.m TestReplicationTasks
go test -v ./common/persistence/sql/sqlplugin/mysql -testify.m TestCreateGetShardBackfill
go test -v ./common/persistence/sql/sqlplugin/mysql -testify.m TestCreateGetUpdateGetShard

go test -v ./common/persistence/sql/sqlplugin/postgres -testify.m TestCrossClusterTasks
go test -v ./common/persistence/sql/sqlplugin/postgres -testify.m TestGetShard
go test -v ./common/persistence/sql/sqlplugin/postgres -testify.m TestUpdateShard
go test -v ./common/persistence/sql/sqlplugin/postgres -testify.m TestReplicationTasks
go test -v ./common/persistence/sql/sqlplugin/postgres -testify.m TestCreateGetShardBackfill
go test -v ./common/persistence/sql/sqlplugin/postgres -testify.m TestCreateGetUpdateGetShard

Potential risks

Release notes

Documentation Changes

@demirkayaender demirkayaender requested a review from a team June 14, 2021 16:57
@yycptt yycptt requested a review from a team June 14, 2021 20:26
@demirkayaender demirkayaender force-pushed the sql_cross branch 3 times, most recently from 70ec4e1 to ae53312 Compare June 15, 2021 22:22
Copy link
Contributor

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the idl submodule before landing.

common/persistence/sql/sqlplugin/postgres/execution.go Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build d3d1b5d3-c959-42ef-b095-937fe7e867cf

  • 122 of 289 (42.21%) changed or added relevant lines in 13 files are covered.
  • 9 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.001%) to 60.19%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/serialization/proto_decoder.go 0 2 0.0%
common/persistence/serialization/proto_encoder.go 0 2 0.0%
common/persistence/sql/sqlplugin/mysql/execution.go 13 15 86.67%
common/persistence/sql/sqlplugin/postgres/execution.go 13 15 86.67%
common/persistence/serialization/thrift_encoder.go 0 3 0.0%
common/persistence/persistence-tests/shardPersistenceTest.go 0 4 0.0%
common/persistence/sql/sqlShardStore.go 43 48 89.58%
common/persistence/serialization/getters.go 4 10 40.0%
common/persistence/serialization/thrift_decoder.go 0 6 0.0%
common/persistence/serialization/thrift_mapper.go 36 42 85.71%
Files with Coverage Reduction New Missed Lines %
common/persistence/persistence-tests/executionManagerTest.go 1 0%
common/persistence/persistence-tests/shardPersistenceTest.go 2 0%
common/task/parallelTaskProcessor.go 2 92.48%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/matching/matcher.go 2 91.46%
Totals Coverage Status
Change from base Build 83a9cc8a-83ee-4d9e-8a91-ea965bf8657f: 0.001%
Covered Lines: 89161
Relevant Lines: 148133

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants