Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert transfer to cross cluster task if target domain is active in remote cluster #4268

Merged
merged 6 commits into from
Jun 22, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Jun 10, 2021

What changed?

  • Convert transfer to cross cluster task if target domain is active in remote cluster
  • Refactor unit test for transfer active task executor

Why?
Cross domain task life cycle

How did you test it?
Unit test

Potential risks
N/A, no cross cluster task will be generated right now

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Jun 10, 2021

Pull Request Test Coverage Report for Build 633fd2bf-3557-42ce-943e-bda915bc8527

  • 44 of 52 (84.62%) changed or added relevant lines in 2 files are covered.
  • 90 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.02%) to 60.146%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/task/transfer_active_task_executor.go 40 48 83.33%
Files with Coverage Reduction New Missed Lines %
client/history/client.go 2 44.35%
client/history/metricClient.go 2 49.43%
common/membership/rpServiceResolver.go 2 73.58%
common/persistence/executionManager.go 2 75.5%
common/persistence/statsComputer.go 2 95.71%
service/history/execution/mutable_state_builder.go 2 69.87%
service/history/handler.go 2 46.67%
service/history/queue/timer_queue_processor.go 2 58.77%
common/task/fifoTaskScheduler.go 4 83.51%
service/frontend/workflowHandler.go 4 58.48%
Totals Coverage Status
Change from base Build 60b59472-1dae-4c2b-bc35-275ee62aac27: -0.02%
Covered Lines: 89875
Relevant Lines: 149428

💛 - Coveralls

@yycptt yycptt merged commit ddfc127 into uber:master Jun 22, 2021
@yycptt yycptt deleted the transfer-to-cross-cluster branch June 22, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants