Update generating close event to use event version #4261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Jun 8, 2021
| return taskGenerator.GenerateWorkflowCloseTasks( | ||
| now, | ||
| closeEvent, |
There was a problem hiding this comment.
it's possible that the closeEvent returned is nil even when error is nil right? then it will cause a NPE in taskGenerator?
There was a problem hiding this comment.
Will return error when close event is nil
| ) (*types.HistoryEvent, error) { | ||
|
|
||
| if e.GetExecutionInfo().CloseStatus == persistence.WorkflowCloseStatusNone { | ||
| return nil, nil |
There was a problem hiding this comment.
not sure if it's better to return an error here. Usually caller will assume historyEvent is not nil when error is nil?
There was a problem hiding this comment.
Will return error when close event is nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update generating close event to use event version
Why?
The task refresher may generate a task with newer version and gets ignored later
How did you test it?
Unit tests.
Potential risks
If there is bugs with this change, there could be race condition in handling closed event
Release notes
Documentation Changes