-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Cassandra client proto version as config option #4188
Adding Cassandra client proto version as config option #4188
Conversation
…rsion was not added
Pull Request Test Coverage Report for Build 59ee0c23-3cf3-419a-827b-55640ee1a407
💛 - Coveralls |
Hi @vytautas-karpavicius, friendly ping to review this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
…rsion was not added
…rsion was not added
…of github.com:noiarek/cadence into rodrigo.villarreal/adding-proto-version-as-config-var
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yycptt I've addressed your comments and also modified other files where Protoversion
might be needed.
Two things to add:
- I don't know if this is related to my change but I'm getting an error when I run
make bins
. This is not allowing me to run the test in local
common/types/mapper/thrift/shared.go:3415:3: unknown field 'NextEventId' in struct literal of type shared.PollForDecisionTaskResponse
common/types/mapper/thrift/shared.go:3439:31: t.GetNextEventId undefined (type *shared.PollForDecisionTaskResponse has no field or method GetNextEventId)
- The change is quite big already (not only to review but to merge). I'm happy to split this in smaller changes if you want me to (i.e add compatibility first and then modified config files)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think make bins
failed because the IDL submodule is changed to an old version so the generated thrift files are also changed. The build and test should pass once you updated the IDL to the latest commit 68a720ef059629a0cba5db58f71053100acb7f19 by using git submodule update --remote
What changed?
ProtoVersion can now be defined in development.yaml. If not present, the default value will be 4.
Why?
Labeled as
Up for grabs
asgood first issue
in #3536How did you test it?
Playing with some values in the development.yaml file. Happy to add some unit test if you indicate me where
Potential risks
There was a default value set in
newCassandraCluster
, however the value is sent by value and not by reference so it won't be set somewhere else. Potentially the right place would betools/cassandra/handler.go
but please let me know where you think I should set this value in case this is not the right placeRelease notes
Maybe? Let me know if you want me to do that
Documentation Changes
Likely to be the case. Let me know if I need to do this.