update startedEventId in buffered events #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 96474b1 on yiminc:update_startedEventId_in_history into ** on uber:master**. |
samarabbas
reviewed
Oct 26, 2017
| case workflow.EventTypeActivityTaskStarted: | ||
| // need to update startedEventId in mutableState if it is still there | ||
| scheduledEventId := event.ActivityTaskStartedEventAttributes.GetScheduledEventId() | ||
| if ai, ok := e.GetActivityInfo(scheduledEventId); ok { |
There was a problem hiding this comment.
Can you check if creating 2 updates in the same transaction for same activityInfo will work?
| e.updateActivityInfos = append(e.updateActivityInfos, ai) | ||
| } | ||
| // update subsequent buffered events in this batch that have reference to the startedEventId | ||
| for j := i + 1; j < len(newCommittedEvents); j++ { |
There was a problem hiding this comment.
I think we should be able to update all events in a single pass. I'm not sure this N^2 algorithm is needed here.
| for j := i + 1; j < len(newCommittedEvents); j++ { | ||
| closeEvent := newCommittedEvents[j] | ||
| switch closeEvent.GetEventType() { | ||
| case workflow.EventTypeChildWorkflowExecutionCompleted: |
There was a problem hiding this comment.
I think there is one more event 'StartChildWorkflowExecutionFailedEvent'
samarabbas
approved these changes
Oct 26, 2017
|
Changes Unknown when pulling eee50fe on yiminc:update_startedEventId_in_history into ** on uber:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update startedEventId in buffered events.