Fix and update docker #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use Cassandra 3.11; fix Readme for docker; add debug tools/log
|
|
venkat1109
approved these changes
Oct 9, 2017
docker/Dockerfile
Outdated
| # Specify the cadence version to be built into this docker image | ||
| # See https://github.com/uber/cadence/tags | ||
| ARG build_branch | ||
| RUN if [ -z "$build_branch" ]; then echo "build_branch NOT SET - ERROR"; exit 1; else : ; fi |
There was a problem hiding this comment.
nit: name the arg as git_branch - build is redundant
There was a problem hiding this comment.
on the error message, print the actual usage i.e. "--build-arg build_branch="
docker/README.md
Outdated
| docker-compose stop | ||
| docker-compose build | ||
| cd $GOPATH/src/github.com/uber/cadence/docker | ||
| docker build . -t ubercadence/server:master --build-arg build_branch=YOUR_CHECKOUT_BRANCH |
There was a problem hiding this comment.
replace ":master" with $git_branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add param to Dockerfile for build_tag;
Fix issue about RINGPOP_SEED;
Use Cassandra 3.11;
Fix Readme for docker; add debug tools/log;
Update docker-compose