easy: Cleanup the go.mod/sum files #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
approved these changes
May 21, 2020
Some of the modules are not used anymore, run `go mod tidy` to perform a quick cleanup.
aleksejuber
force-pushed
the
cleanup_go_mod
branch
from
383f88b
to
54a1ba4
Compare
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Some of the modules are not used anymore, run `go mod tidy` to perform a quick cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the modules are not used anymore, run
go mod tidyto perform aquick cleanup.
What changed?
A couple of modules are removed from the list using go mod automation
Why?
These changes will appear whenever next
go get ...command gets executed, which creates confusing unrelated changes to the module list. Let's cleanup the module list proactively.How did you test it?
Building the service locally, and BuildKite builds.
Potential risks
Worst case scenario is builds being broken. Revert the PR to fully revert the changes.