Better postgresql test defaults on OSX #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
reviewed
May 7, 2020
sheerun
force-pushed
the
better-postgres-defaults
branch
from
99fbdd9
to
c9e7452
Compare
yux0
reviewed
May 8, 2020
sheerun
force-pushed
the
better-postgres-defaults
branch
from
c9e7452
to
a47e032
Compare
|
I hope it's acceptable now |
yux0
approved these changes
May 8, 2020
mkolodezny
pushed a commit
to mkolodezny/cadence
that referenced
this pull request
May 11, 2020
Co-authored-by: Liang Mei <meiliang86@gmail.com> Co-authored-by: Yichao Yang <ycyang@uber.com>
yux0
pushed a commit
to yux0/cadence
that referenced
this pull request
May 4, 2021
Co-authored-by: Liang Mei <meiliang86@gmail.com> Co-authored-by: Yichao Yang <ycyang@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
go test -v github.com/uber/cadence/common/persistence/sql/sqlplugin/postgresPotential risks
Can fail if someone has already configured postgresql in non-standard way with postgres / cadence username / password on OSX