Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent git from ignoring "cadence" directory #3236

Merged
merged 3 commits into from
May 6, 2020

Conversation

sheerun
Copy link
Contributor

@sheerun sheerun commented May 5, 2020

This fixes .gitignore file so only top-level binaries are ignored by git, not directories with the same names.

Why?

Tools like silversearcher and ripgrep respect .gitignore so they don't show search results from schema/cassandra/cadence directory. Also git ignores new files that are added there.

How did you test it?

I've verified that files in schema/cassandra/cadence are searchable with ripgrep and silversearcher, and that new files in there are not ignored by git status.

Potential risks

None

@CLAassistant
Copy link

CLAassistant commented May 5, 2020

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 68.25% when pulling dd2eb50 on sheerun:fix-ignores into e36e80b on uber:master.

@meiliang86 meiliang86 merged commit 3deebda into uber:master May 6, 2020
mkolodezny pushed a commit to mkolodezny/cadence that referenced this pull request May 11, 2020
Co-authored-by: Liang Mei <meiliang86@gmail.com>
yux0 pushed a commit to yux0/cadence that referenced this pull request May 4, 2021
Co-authored-by: Liang Mei <meiliang86@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants