Add feature flag to not fail in flight decision #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
changed the title
yux0
changed the title
yycptt
approved these changes
Apr 7, 2020
|
Please add some comments in the code explaining the idea of this pr. I guess we may need to re-visit this solution in the future. |
yux0
added a commit
that referenced
this pull request
Apr 7, 2020
yux0
added a commit
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Check if there is buffered event prior to add a decision task fail.
Why?
We fail the decision to make sure the versions of events inside one batch are the same. However, this blocks replicating missing workflow from another cluster.
For example:
How did you test it?
local two clusters test
Potential risks
In the worst case, the versions inside one batch will be different.