Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up priority task processor implementation #3146

Merged
merged 4 commits into from
Mar 31, 2020

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Mar 27, 2020

What changed?
Wire up implementations for priority task processor

Why?
Priority task processor is part of the multi-tenancy effort for throttling task processing for bursty domains

How did you test it?
Tested locally with feature flag turned both on and off through unit and integration test.

Potential risks
No risk when the feature flag is turned off.
If the flag is turned on, may impact performance.

@yycptt yycptt requested review from yux0 and a team March 27, 2020 17:42
@coveralls
Copy link

coveralls commented Mar 27, 2020

Coverage Status

Coverage decreased (-0.04%) to 67.04% when pulling 90e7dac on yycptt:wire-up-task-processor into 882f680 on uber:master.

common/task/weightedRoundRobinTaskScheduler.go Outdated Show resolved Hide resolved
service/history/handler.go Outdated Show resolved Hide resolved
service/history/queueProcessor.go Show resolved Hide resolved
service/history/timerQueueProcessorBase.go Show resolved Hide resolved
@yycptt yycptt merged commit 97e0c83 into uber:master Mar 31, 2020
@yycptt yycptt deleted the wire-up-task-processor branch March 31, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants