Add metrics to AccessControlledHandler #3145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -121,11 +121,15 @@ func (a *AccessControlledWorkflowHandler) DeprecateDomain( | |||
| request *shared.DeprecateDomainRequest, | |||
| ) error { | |||
|
|
|||
| scope := a.GetResource().GetMetricsClient(). | |||
There was a problem hiding this comment.
Can we use getMetricsScopeWithDomain here?
There was a problem hiding this comment.
Request in XXXDomain APIs are not domainGetter, so hard to reuse. But I make it a function to some some lines.
| } | ||
|
|
||
| // getMetricsScopeWithDomain return metrics scope with domain tag | ||
| func (a *AccessControlledWorkflowHandler) getMetricsScopeWithDomain( |
There was a problem hiding this comment.
How about just making the following method a utility method that takes in a metrics client instead of duplicating the code
// startRequestProfileWithDomain initiates recording of request metrics and returns a domain tagged scope
func (wh *WorkflowHandler) startRequestProfileWithDomain(scope int, d domainGetter) (metrics.Scope, metrics.Stopwatch) {
var metricsScope metrics.Scope
if d != nil {
metricsScope = wh.GetMetricsClient().Scope(scope).Tagged(metrics.DomainTag(d.GetDomain()))
} else {
metricsScope = wh.GetMetricsClient().Scope(scope).Tagged(metrics.DomainUnknownTag())
}
sw := metricsScope.StartTimer(metrics.CadenceLatency)
metricsScope.IncCounter(metrics.CadenceRequests)
return metricsScope, sw
}
andrewjdawson2016
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add metrics to AccessControlledHandler
Why?
For monitoring authorization status
How did you test it?
Unit test
Potential risks
No risk