Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding json tags for ShardInfo struct to reuse for docstore #3127

Merged
merged 3 commits into from
Mar 24, 2020

Conversation

anish531213
Copy link
Contributor

@anish531213 anish531213 commented Mar 23, 2020

What changed?
Added json tag for ShardInfo for docstore shardManager implementation. TimerFailoverLevels and TransferFailoverLevels are not used as these are not persisted.

Why?

How did you test it?

Potential risks

@anish531213 anish531213 requested review from vitarb and a team March 23, 2020 22:46
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 67.498% when pulling a792fa8 on anish531213:aanish/update-shard-info into 74c2c69 on uber:master.

@anish531213 anish531213 merged commit da43539 into uber:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants