Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup PersistenceTestCluster interface #3112

Merged
merged 3 commits into from
Mar 13, 2020
Merged

Cleanup PersistenceTestCluster interface #3112

merged 3 commits into from
Mar 13, 2020

Conversation

vitarb
Copy link
Contributor

@vitarb vitarb commented Mar 13, 2020 •
edited
Loading

This change removes methods that are not generic enough and are only used in the internal implementation details.

Methods being deleted are never used through the interface and are only referenced from within other methods of the same interface.

@coveralls
Copy link

coveralls commented Mar 13, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 67.154% when pulling 53c7960 on vitarb:cleanup-persistence-test-interface into bb7d24d on uber:master.

@vitarb vitarb requested a review from a team March 13, 2020 02:08
@vitarb vitarb merged commit 36a48c3 into uber:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitarb @coveralls @yux0