Add Activity E2E latency metrics #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vancexu
commented
Mar 12, 2020
meiliang86
reviewed
Mar 12, 2020
| RunID string `json:"runId"` | ||
| ScheduleID int64 `json:"scheduleId"` | ||
| ScheduleAttempt int64 `json:"scheduleAttempt"` | ||
| ActivityID string `json:"activityId"` | ||
| ActivityType string `json:"activityType"` | ||
| TaskList string `json:"taskList"` |
There was a problem hiding this comment.
ActivityInfo already has task list. So you don't need to add it here.
meiliang86
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add new metric
activity_end_to_end_latencyfor activityWhy?
Currently, there is no cadence metrics on activity e2e latency available for customer. The cadence client (both go and java) had activity execution and e2e latency metrics, but they are not correct for async activity completion (and no easy way to get it correctly on client side).
How did you test it?
Will be tested in staging before release.
Potential risks
No risk.
Only adding load on metrics dependency.