Add canary test for visibility archival #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canary/archival.go
Outdated
| listReq.NextPageToken = listResp.NextPageToken | ||
| } | ||
|
|
||
| if len(listResp.Executions) == 0 { |
There was a problem hiding this comment.
Roughly how many do we expect to have here? Seems like if we can assert something stronger than more than 0 it would be good.
There was a problem hiding this comment.
I put more thought on this last night and made the following two changes:
- Separate the canary test for history archival and visibility archival so they can be enabled or disabled independently.
- Created an interface for validating visibility archival (a template) which each visibility archival scheme should implement. It basically tells canary if the test should be run, what the query is and how the result should be validated. With this interface, I believe the code is general enough for all archiver implementations and each implementation can have more control over the test.
I made those changes because I think when open source customers use canary in production, it's unlikely they will set the scheme for canary domain to be filestore, it will be either s3 or gcp or some other implementation. So we should make the code more general and flexible.
What's your thought on this?
There was a problem hiding this comment.
This makes a lot of sense :)
andrewjdawson2016
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.