Separate logic for timer task execution and queue management #3039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for deprecating the current taskProcessor, taskExecutor and taskInfo defined in history package and in favor of the task interface defined in common/task package.
Separating the logic for queue management and task processing make the code easier to read and understand.
Executor (and also task metric scope) will be assigned to a task when the task is created and sent for processing.
When implementing NDC task life cycle, we can consider combine the executor for active and standby processing into one executor and let the executor to decide if the task should be executed as active or passive. This can't be done without this refactoring.
Will send out separate PR for transfer and replication task