-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mutable state checksums part#2: persistence changes #2967
Conversation
@@ -0,0 +1,8 @@ | |||
{ | |||
"CurrVersion": "0.24", | |||
"MinCompatibleVersion": "0.23", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.24?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is backwards compatible with 0.23 and so this is set to 0.23
@@ -244,6 +246,7 @@ type ( | |||
SignalInfos map[int64]*SignalInfo | |||
SignalRequestedIDs map[string]struct{} | |||
BufferedEvents []*DataBlob | |||
Checksum checksum.Checksum | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would put checksum in a seperate group, e.g.
InternalWorkflowMutableState struct {
ExecutionInfo *InternalWorkflowExecutionInfo
ReplicationState *ReplicationState
VersionHistories *DataBlob
ActivityInfos map[int64]*InternalActivityInfo
TimerInfos map[string]*TimerInfo
ChildExecutionInfos map[int64]*InternalChildExecutionInfo
RequestCancelInfos map[int64]*RequestCancelInfo
SignalInfos map[int64]*SignalInfo
SignalRequestedIDs map[string]struct{}
BufferedEvents []*DataBlob
Checksum checksum.Checksum
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is simply personal preference. In general, this is something that is not auto enforcable by gofmt etc. And so, over time, your personal preference for grouping this separately is not sustainable. I will group this separately for now. But philosophically, I am not a big fan these type of semi-enforced groupings (unless there is strong reasons like struct packing in C/C++)
one more thing, where is the impl for SQL? |
|
b4a47ea
to
ebaf241
Compare
This patch contains the cassandra persistence changes to support mutable state checksums. This is a follow up to #2941