Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backward compatible feature version check when clientImpl is not set #2906

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Backward compatible feature version check when clientImpl is not set #2906

merged 2 commits into from
Dec 13, 2019

Conversation

andrewjdawson2016
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Dec 12, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 67.825% when pulling ab538e9 on andrewjdawson2016:FeatureVersionCheck into 1e63e93 on uber:master.

venkat1109
venkat1109 approved these changes Dec 13, 2019
View reviewed changes
common/client/versionChecker.go Outdated Show resolved Hide resolved
@andrewjdawson2016 andrewjdawson2016 merged commit 1c6aa68 into uber:master Dec 13, 2019
@andrewjdawson2016 andrewjdawson2016 deleted the FeatureVersionCheck branch December 13, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venkat1109 venkat1109 venkat1109 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewjdawson2016 @coveralls @venkat1109