Concurrent shard loading #2888
Merged
Concurrent shard loading #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkat1109
reviewed
Dec 5, 2019
venkat1109
approved these changes
Dec 5, 2019
- added a test for concurrent shard loading - refactored code to use worker pool instead of channel. - added comments - set size of wg and shardActionCh to concurrency instead of number of shards - spawning workers early before writing data to the channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces ability to acquire shards concurrently.
Although underlying shardController's operations like get/remove engine are synchronized there should still be noticeable speed up due to the increased parallelism.
Note that default value for the concurrent number of goroutines is 1 meaning that it would use one thread for loading (e.g. no change from the pervious behavior).
Users would need to change history.acquireShardConcurrency property in the dynamic config in order to use higher number of goroutines.
We may consider changing this default in future once the change is tested.