Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing properties in continueasnew when workflow fail #2883

Merged
merged 4 commits into from
Dec 3, 2019
Merged

Fix missing properties in continueasnew when workflow fail #2883

merged 4 commits into from
Dec 3, 2019

Conversation

vancexu
Copy link
Contributor

@vancexu vancexu commented Dec 3, 2019 •
edited
Loading

@vancexu vancexu requested a review from yycptt December 3, 2019 22:42
yycptt
yycptt approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do we have any unit test for processWorkflowTimeout? If so, maybe a good idea to also update those tests.

@vancexu vancexu merged commit 1753126 into master Dec 3, 2019
@vancexu vancexu deleted the fixc branch December 3, 2019 23:22
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 67.372% when pulling 3de7626 on fixc into 38ba642 on master.

@vancexu
Copy link
Contributor Author

vancexu commented Dec 3, 2019

Looks good to me. Do we have any unit test for processWorkflowTimeout? If so, maybe a good idea to also update those tests.

Good suggestion. Unfortunately we don't have such unit tests on timer tasks so I turned to integration tests. It would be great to revisit

vancexu added a commit that referenced this pull request Dec 3, 2019
@vancexu
Fix missing properties in continueasnew when workflow fail (#2883)
a725304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yycptt yycptt yycptt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vancexu @coveralls @yycptt