Fix race condition in integration test #2871
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a temp fix for the race condition of persistence config. The race condition for archiver provider happens only in the integration test as in the test all services shares one archiver provider.
The race condition for persistence config happens because all the services are using the same persistence config (the datastore map in particular) and will retry to modify the maxQPS during start up and use the modified maxQPS value to create a persistence factory.
We need to come up with a better way to resolve this race condition. One idea is to remove all the pointers in the config definition, which makes every copy of persistence config a deep copy.