Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in integration test #2871

Merged
merged 5 commits into from
Nov 27, 2019
Merged

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Nov 26, 2019

This is just a temp fix for the race condition of persistence config. The race condition for archiver provider happens only in the integration test as in the test all services shares one archiver provider.

The race condition for persistence config happens because all the services are using the same persistence config (the datastore map in particular) and will retry to modify the maxQPS during start up and use the modified maxQPS value to create a persistence factory.

We need to come up with a better way to resolve this race condition. One idea is to remove all the pointers in the config definition, which makes every copy of persistence config a deep copy.

host/onebox.go Outdated Show resolved Hide resolved
host/onebox.go Outdated Show resolved Hide resolved
host/onebox.go Outdated Show resolved Hide resolved
host/onebox.go Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 26, 2019

Coverage Status

Coverage decreased (-0.7%) to 67.262% when pulling c464cd8 on yycptt:fix-int-race into 41f1acc on uber:master.

@yycptt yycptt merged commit dc5f154 into uber:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants