New persistence client bean for DB clients management #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
common/persistence/client/bean.go
Outdated
| ) | ||
|
|
||
| // NewBeanByFactory crate a new store bean using factory | ||
| func NewBeanByFactory( |
There was a problem hiding this comment.
How about NewBeanFromFactory?
common/persistence/client/factory.go
Outdated
| @@ -44,8 +44,8 @@ type ( | |||
| NewTaskManager() (p.TaskManager, error) | |||
| // NewShardManager returns a new shard manager | |||
| NewShardManager() (p.ShardManager, error) | |||
| // NewHistoryV2Manager returns a new historyV2 manager | |||
| NewHistoryV2Manager() (p.HistoryManager, error) | |||
| // NewHistoryManager returns a new historyV2 manager | |||
There was a problem hiding this comment.
could you also fix the comment
|
|
||
| type ( | ||
| // Bean in an collection of persistence manager | ||
| Bean interface { |
There was a problem hiding this comment.
Is it being used anywhere in this PR? or just for future?
There was a problem hiding this comment.
i have a really large commit doing service startup logic refactoring, this is part of that
yycptt
approved these changes
Nov 8, 2019
| @@ -18,7 +18,7 @@ | |||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | |||
| // THE SOFTWARE. | |||
|
|
|||
| package persistence | |||
| package client | |||
There was a problem hiding this comment.
Can we rename the New() function in this file to maybe NewFactory()? I think client.New() returning a persistence factory is kind of counter-intuitive.
longquanzheng
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.