Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint #2700

Merged
merged 3 commits into from
Oct 23, 2019
Merged

Fix lint #2700

merged 3 commits into from
Oct 23, 2019

Conversation

vancexu
Copy link
Contributor

@vancexu vancexu commented Oct 23, 2019

been there for too long....

@vancexu vancexu requested a review from yycptt October 23, 2019 00:00
@coveralls
Copy link

coveralls commented Oct 23, 2019

Coverage Status

Coverage decreased (-0.4%) to 66.786% when pulling e585254 on lint into 74c2327 on master.

@vancexu vancexu merged commit 351b3fd into master Oct 23, 2019
@vancexu vancexu deleted the lint branch October 23, 2019 17:29
@vancexu
Copy link
Contributor Author

vancexu commented Oct 23, 2019

It turns out to be my local lint is not using latest version, and the complains is removed from latest lint.
Using following to update lint and other tools.

export GO111MODULE=off                                                                                                                         
go get -u -v github.com/ramya-rao-a/go-outline                                                                                                 
go get -u -v github.com/acroca/go-symbols                                                                                                      
go get -u -v github.com/nsf/gocode                                                                                                             
go get -u -v github.com/rogpeppe/godef                                                                                                         
go get -u -v golang.org/x/tools/cmd/godoc                                                                                                      
go get -u -v github.com/zmb3/gogetdoc                                                                                                          
go get -u -v github.com/golang/lint/golint                                                                                                     
go get -u -v github.com/fatih/gomodifytags                                                                                                     
go get -u -v github.com/uudashr/gopkgs/cmd/gopkgs                                                                                              
go get -u -v golang.org/x/tools/cmd/gorename                                                                                                   
go get -u -v sourcegraph.com/sqs/goreturn                                                                                                      
go get -u -v golang.org/x/tools/cmd/goimports                                                                                                  
go get -u -v github.com/cweill/gotests/...                                                                                                     
go get -u -v golang.org/x/tools/cmd/guru                                                                                                       
go get -u -v golang.org/x/lint/golint                                                                                                          
go get -u -v github.com/josharian/impl                                                                                                         
go get -u -v github.com/haya14busa/goplay/cmd/goplay                                                                                           
go get -u -v github.com/uudashr/gopkgs/cmd/gopkgs                                                                                              
go get -u -v github.com/fatih/gomodifytags                                                                                                     
go get -u -v github.com/davidrjenni/reftools/cmd/fillstruct                                                                                    
go get -u -v github.com/sourcegraph/go-langserver                                                                                              
go get -u -v github.com/derekparker/delve/cmd/dlv                                                                                              
go get -u -v github.com/golang/mock/gomock                                                                                                     
go get -u -v github.com/golang/mock/mockgen                                                                                                    
export GO111MODULE=auto   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants