Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary user timer API in timer builder #2659

Merged
merged 3 commits into from
Oct 11, 2019
Merged

Remove unnecessary user timer API in timer builder #2659

merged 3 commits into from
Oct 11, 2019

Conversation

wxing1292
Copy link
Contributor

@wxing1292 wxing1292 commented Oct 11, 2019 •
edited
Loading

  • Remove AddUserTimer in timerBuilder
  • User timer generation is handled by closeTransactionHandleActivityUserTimerTasks in mutableState

solve #1046

Remove unnecessary add user timer API in timer builder
e3ee0f3 
* Remove AddUserTimer in timerBuilder
* User timer generation is handled by closeTransactionHandleActivityUserTimerTasks in mutableState
@coveralls
Copy link

coveralls commented Oct 11, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-1.0%) to 66.688% when pulling 576b7e2 on remove-unnecessary-insertion-timer-builder into 44f69c7 on master.

@wxing1292 wxing1292 merged commit dda75d0 into master Oct 11, 2019
@wxing1292 wxing1292 deleted the remove-unnecessary-insertion-timer-builder branch October 11, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

@vancexu vancexu Awaiting requested review from vancexu

@meiliang86 meiliang86 Awaiting requested review from meiliang86

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wxing1292 @coveralls @yux0