Refactor metrics with domain tag #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func (t *timerQueueActiveProcessorImpl) getMetricScopeWithDomainTag(scope int, domainID string) (metrics.Scope, error) { | ||
| domainEntry, err := t.shard.GetDomainCache().GetDomainByID(domainID) | ||
| if err != nil { | ||
| return nil, &workflow.InternalServiceError{Message: "unable to get domain from cache by domainID."} |
There was a problem hiding this comment.
Actually we should return this error instead of making a new one. Because the err from domainCache could should have more useful info than this simple text.
There was a problem hiding this comment.
make sense. updated
longquanzheng
approved these changes
Aug 14, 2019
neil-xie
added a commit
that referenced
this pull request
Jul 8, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 9, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 12, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 13, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 15, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 15, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 16, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 16, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 16, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 16, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 16, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 16, 2022
* Add new es record for uninitialized workflow (#2386) * Add nil check for visibility manager when adding uninitialized wf execution record (#2386) * Update TestProcessRecordWorkflowStartedTask to include unit test for record wf execution uninitialized method * Fix the test add method of es processor (#2386) * Disable the feature by default (#2386) * Fix the unit test when feature is disabled * Fix the unit test when feature is disabled (#2386)
neil-xie
added a commit
that referenced
this pull request
Jul 18, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 18, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 18, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 18, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 18, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 18, 2022
neil-xie
added a commit
that referenced
this pull request
Jul 18, 2022
abhishekj720
pushed a commit
to abhishekj720/cadence
that referenced
this pull request
Jul 21, 2022
* Add new es record for uninitialized workflow (uber#2386) * Add nil check for visibility manager when adding uninitialized wf execution record (uber#2386) * Update TestProcessRecordWorkflowStartedTask to include unit test for record wf execution uninitialized method * Fix the test add method of es processor (uber#2386) * Disable the feature by default (uber#2386) * Fix the unit test when feature is disabled * Fix the unit test when feature is disabled (uber#2386)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small efforts to reduce some duplicates