Remove unused file and docker release instruction(moved to internal) #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmetzgar
reviewed
May 10, 2019
CONTRIBUTING.md
Outdated
| ```bash | ||
| cd github.com/uber/cadence/docker | ||
| tar -cvf docker.tar.gz * | ||
| ``` |
There was a problem hiding this comment.
This whole section should be in the internal docs. People contributing to Cadence server won't have permission to push to our Docker or add a release.
There was a problem hiding this comment.
Yes, that's true. It's also nice to have the release process in a single place rather than split into external and internal. I will move it.
longquanzheng
changed the title
dmetzgar
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the release instruction to our internal wiki