Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add support for workflow retry params #1460

Merged
merged 2 commits into from
Feb 13, 2019

Conversation

venkat1109
Copy link
Contributor

@venkat1109 venkat1109 commented Feb 13, 2019

Note to Reviewer:
The 'executions' table at this point has close to 50 columns. We could consider storing the mutable state as a blob in MySQL - however the pros/cons of doing so are not very clear at this time. So, I have decided to tackle this problem independently after getting some data on the performance implications of such a change.

Pros/Cons to having too many columns are below. The I/O cost is likely to be the same with both blob and wide rows

  • Cons

    • CPU cost on the MySQL server to do conversions to/from blobs obtained from InnoDB
    • Mutable state (executions) is something we expect to add/deprecate columns frequently. In a sharded mysql cluster, schema changes may be hard i.e. all storage shards must agree on the new schema despite operating independently - this may or may not add operational complexity
  • Pros

    • Allows for joins on non-primary key fields - but we likely don't need this flexibility

@venkat1109 venkat1109 self-assigned this Feb 13, 2019
@venkat1109 venkat1109 added the sql Support for SQL databases (ie. MySQL) label Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sql Support for SQL databases (ie. MySQL)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix sql to support workflow retry
2 participants