CLI: add security token to admin add search attribute (#2773)

uber · Nov 6, 2019 · ca0897b · ca0897b
1 parent 6120c99
commit ca0897b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/tools/cli/admin.go b/tools/cli/admin.go
@@ -689,6 +689,10 @@ func newAdminClusterCommands() []cli.Command {
 					Value: -1,
 					Usage: "Search Attribute value type. [0:String, 1:Keyword, 2:Int, 3:Double, 4:Bool, 5:Datetime]",
 				},
+				cli.StringFlag{
+					Name:  FlagSecurityTokenWithAlias,
+					Usage: "Optional token for security check",
+				},
 			},
 			Action: func(c *cli.Context) {
 				AdminAddSearchAttribute(c)

diff --git a/tools/cli/adminClusterCommands.go b/tools/cli/adminClusterCommands.go
@@ -27,10 +27,10 @@ import (
 	"strings"
 
 	"github.com/fatih/color"
-	"github.com/urfave/cli"
-
 	"github.com/uber/cadence/.gen/go/admin"
 	"github.com/uber/cadence/.gen/go/shared"
+	"github.com/uber/cadence/common"
+	"github.com/urfave/cli"
 )
 
 // AdminAddSearchAttribute to whitelist search attribute
@@ -58,6 +58,7 @@ func AdminAddSearchAttribute(c *cli.Context) {
 		SearchAttribute: map[string]shared.IndexedValueType{
 			key: shared.IndexedValueType(valType),
 		},
+		SecurityToken: common.StringPtr(c.String(FlagSecurityToken)),
 	}
 
 	err := adminClient.AddSearchAttribute(ctx, request)

diff --git a/tools/cli/domainUtils.go b/tools/cli/domainUtils.go
@@ -86,7 +86,7 @@ var (
 		},
 		cli.StringFlag{
 			Name:  FlagSecurityTokenWithAlias,
-			Usage: "Security token with permission",
+			Usage: "Optional token for security check",
 		},
 		cli.StringFlag{
 			Name:  FlagHistoryArchivalStatusWithAlias,
@@ -140,7 +140,7 @@ var (
 		},
 		cli.StringFlag{
 			Name:  FlagSecurityTokenWithAlias,
-			Usage: "Security token with permission ",
+			Usage: "Optional token for security check",
 		},
 		cli.StringFlag{
 			Name:  FlagHistoryArchivalStatusWithAlias,