Fix leaking kafka consumer (#1062)

uber · Aug 21, 2018 · 71e126f · 71e126f
1 parent 0300251
commit 71e126f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/common/messaging/kafkaClient.go b/common/messaging/kafkaClient.go
@@ -101,7 +101,7 @@ func (c *kafkaConsumer) Start() error {
 			select {
 			case <-c.doneC:
 				c.logger.Info("Stop consuming messages from channel")
-				break
+				return
 				// our Message interface is just a subset of Message interface in kafka-client so we don't need a wrapper here
 			case uMsg := <-c.uConsumer.Messages():
 				c.msgC <- uMsg