Skip to content

Commit

Permalink
Running each on their own line fixes the issue (#5614)
Browse files Browse the repository at this point in the history
What changed?
Split the different runs into their own lines, so the whole script fails when one of them fails.

Linting is expected to fail as the lint issues fixed in this PR #5613 is not merged yet

Why?
Currently the script will not fail even though the lint fails

How did you test it?
Tested locally
  • Loading branch information
jakobht authored Jan 22, 2024
1 parent 6c56c4c commit 5e3da71
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion scripts/buildkite/golint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@

set -ex

make go-generate && make fmt && make lint && make copyright
make go-generate
make fmt
make lint
make copyright

# intentionally capture stderr, so status-errors are also PR-failing.
# in particular this catches "dubious ownership" failures, which otherwise
Expand Down

0 comments on commit 5e3da71

Please sign in to comment.