Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vue-virtual-scroller 1.0.10 #624

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

adhityamamallan
Copy link
Contributor

@adhityamamallan adhityamamallan commented Aug 1, 2024

The latest compatible (with package.json) release of vue-virtual-scroller (1.1.2) has an issue where scrollToItem breaks if a gridSize is not mentioned. This causes a bug on the Workflow History page where selecting any item in the activity list causes the entire list to snap back up, which adversely affects UX with longer activity lists.

Since the lockfile already uses 1.0.10, this PR downgrades the version in package.json to match it, so that anyone using cadence-web as an NPM package also gets vue-virtual-scroller 1.0.10.

@Assem-Uber Assem-Uber merged commit 4dafe97 into master Aug 1, 2024
5 checks passed
@Assem-Uber Assem-Uber deleted the update-vue-virtual-scroller branch August 1, 2024 10:28
@Assem-Hafez Assem-Hafez mentioned this pull request Aug 9, 2024
@matteeos
Copy link

Hi, @Assem-Uber issue still exists in the new cadence-web "3.35.5-beta.2".
image

@Assem-Uber
Copy link
Contributor

@matteeos thanks for reporting the problem.
can you please provide the version of vue-virtual-scroller in your package-lock.json

@matteeos
Copy link

it's 1.0.10

    "vue-virtual-scroller": {
      "version": "1.0.10",
      "resolved": "https://unpm.uberinternal.com/vue-virtual-scroller/-/vue-virtual-scroller-1.0.10.tgz",
      "integrity": "sha512-Hn4qSBDhRY4XdngPioYy/ykDjrLX/NMm1fQXm/4UQQ/Xv1x8JbHGFZNftQowTcfICgN7yc31AKnUk1UGLJ2ndA==",
      "requires": {
        "scrollparent": "^2.0.1",
        "vue-observe-visibility": "^0.4.4",
        "vue-resize": "^0.4.5"
      }
    }

@matteeos
Copy link

matching defined in package.json : https://unpkg.com/browse/cadence-web@3.35.5-beta.2/package.json

@Assem-Uber
Copy link
Contributor

@matteeos seems like there is another dependency change causing that issue.
Are you tracking the differences between your package-lock.json before and after the issue ?

@matteeos
Copy link

No, just did a few versions upgrade of cadence and found that issue. I see @kotcrab already have created issue for it #632 so let's continue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants