Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC middleware #599

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Add OIDC middleware #599

merged 4 commits into from
Aug 8, 2024

Conversation

mantas-sidlauskas
Copy link
Contributor

Adding OpenID Connect (OIDC) middleware.

  • The OIDC middleware allows users to authenticate using external identity providers (IdPs) providers. (Okta, AWS Cognito, Auth0, Google, etc)
  • Configuration can be passed as env variables or using dedicated configuration file.
  • Middleware will check for token exp time to avoid situation when expired token is sent to Cadence Server

@Assem-Uber
Copy link
Contributor

Thanks for working on it @mantas-sidlauskas, i'm out for 2 weeks and will take a look once back.

@mantas-sidlauskas
Copy link
Contributor Author

Thanks for working on it @mantas-sidlauskas, i'm out for 2 weeks and will take a look once back.

sure, thanks!

server/middleware/oidc/index.js Show resolved Hide resolved
server/middleware/oidc/index.js Show resolved Hide resolved
server/middleware/oidc/index.js Outdated Show resolved Hide resolved
server/middleware/oidc/index.js Outdated Show resolved Hide resolved
server/middleware/oidc/index.js Outdated Show resolved Hide resolved
@Assem-Uber
Copy link
Contributor

LGTM, can you please add an example usage in the readme file
BTW the build is failing and need to run npm run lint

@mantas-sidlauskas
Copy link
Contributor Author

LGTM, can you please add an example usage in the readme file BTW the build is failing and need to run npm run lint

I'm planning to add README.md in the next PR where I will check in code if this middleware has to be enabled.

@Assem-Uber Assem-Uber merged commit d9a9c51 into uber:master Aug 8, 2024
4 checks passed
@Assem-Hafez Assem-Hafez mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants