Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programatic download/export for workflow history #546

Conversation

Assem-Hafez
Copy link
Contributor

Fixing issue of export button not downloading history for correct origin.
The problem was that the export button is using the current origin to request the information while it should be using the origin related to the domain itself.
In order to fix that, the href was replaced with an onclick handler which fetches the history and create a blob url that can be used for downloading (note: using httpService for fetching handles the origin automatically).

Another changes:

  • Install chai-spies to be used in test cases
  • mock api response for xxx\export api and provide it using withExportHistory
  • update unit tests

@Assem-Uber Assem-Uber merged commit f42e164 into uber:master Mar 27, 2024
4 checks passed
@Assem-Hafez Assem-Hafez mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants