Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/grpc support #481

Merged
merged 145 commits into from
Jun 14, 2022
Merged

Feature/grpc support #481

merged 145 commits into from
Jun 14, 2022

Conversation

just-at-uber
Copy link
Contributor

@just-at-uber just-at-uber commented Jun 2, 2022

Added

  • GRPC support is now available for Cadence UI. By default, to preserve backwards compatibility, the transportClientType will default to 'tchannel'. To switch to 'grpc', you have 1 of 2 options:
    • set environment variable TRANSPORT_CLIENT_TYPE = 'grpc'
    • set configuration passed to server on startup:
      app.init({
        transportClientType: 'grpc',
      }).listen(port)
      
  • GRPC supported in integration tests. To test different configurations, see server/test/cadence-frontend-simulator.js : LN43 to adjust TRANSPORT_CLIENT_TYPE value

Changed

  • TChannel mock is now separated into it's own file (similar to GRPC) for integration tests.
  • Updated Cadence IDL commit hash to latest which contains new proto definitions for GRPC. This is now pulling two folders instead of just the thrift folder and directory references have been adjusted to compensate for this.

…er API request to provide backwards compatible change.
@just-at-uber just-at-uber marked this pull request as ready for review June 9, 2022 20:07
@just-at-uber just-at-uber requested a review from a team June 9, 2022 20:07
@just-at-uber just-at-uber requested review from a team and davidporter-id-au June 13, 2022 23:12
@just-at-uber just-at-uber merged commit bdf04ec into master Jun 14, 2022
@just-at-uber just-at-uber deleted the feature/grpc-support branch June 14, 2022 19:09
@just-at-uber just-at-uber mentioned this pull request Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants