Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dropdown accessibility #476

Merged
merged 2 commits into from
May 19, 2022
Merged

Fix/dropdown accessibility #476

merged 2 commits into from
May 19, 2022

Conversation

just-at-uber
Copy link
Contributor

When upgrading vue-select library in a previous patch release it broke styling for a few dropdowns in the app.
These changes should help fix accessibility issues with the dropdowns.

Screenshots

Environment select

After

Screen Shot 2022-05-19 at 3 08 33 PM

Before

Screen Shot 2022-05-19 at 3 09 36 PM

Domain autocomplete

After

Screen Shot 2022-05-19 at 3 14 38 PM

Before

Screen Shot 2022-05-19 at 3 09 41 PM

Active status

After

Screen Shot 2022-05-19 at 3 08 58 PM

Before

Screen Shot 2022-05-19 at 3 09 46 PM

@just-at-uber just-at-uber requested a review from a team May 19, 2022 22:18
@Groxx
Copy link

Groxx commented May 19, 2022

yea, looking not-disabled is good :) LGTM!

@just-at-uber just-at-uber merged commit b125b7c into master May 19, 2022
@just-at-uber just-at-uber deleted the fix/blank-dropdown branch May 19, 2022 22:42
@just-at-uber just-at-uber mentioned this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants