Add cron schedule to workflow summary page (#526)

* add cron schedule to workflow summary page * fix linting issue
uber · Sep 11, 2023 · cc5ae88 · cc5ae88
1 parent a45534c
commit cc5ae88
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 1 deletion.
diff --git a/client/containers/workflow/component.vue b/client/containers/workflow/component.vue
@@ -49,6 +49,7 @@ export default {
         input: undefined,
         isWorkflowRunning: undefined,
         parentWorkflowRoute: undefined,
+        cronSchedule: undefined,
         result: undefined,
         wfStatus: undefined,
         workflow: undefined,
@@ -147,6 +148,7 @@ export default {
       this.history.loading = undefined;
 
       this.summary.input = undefined;
+      this.summary.cronSchedule = undefined;
       this.summary.isWorkflowRunning = undefined;
       this.summary.parentWorkflowRoute = undefined;
       this.summary.result = undefined;
@@ -395,6 +397,7 @@ export default {
       :display-workflow-id="displayWorkflowId"
       :domain="domain"
       :input="summary.input"
+      :cronSchedule="summary.cronSchedule"
       :isWorkflowRunning="summary.isWorkflowRunning"
       :parentWorkflowRoute="summary.parentWorkflowRoute"
       :result="summary.result"

diff --git a/client/containers/workflow/helpers/get-summary.js b/client/containers/workflow/helpers/get-summary.js
@@ -38,6 +38,7 @@ const getSummary = ({ clusterName, events, isWorkflowRunning, workflow }) => {
     return {
       input: undefined,
       isWorkflowRunning,
+      cronSchedule: undefined,
       parentWorkflowRoute: undefined,
       result: undefined,
       wfStatus: undefined,
@@ -77,6 +78,7 @@ const getSummary = ({ clusterName, events, isWorkflowRunning, workflow }) => {
 
   return {
     input,
+    cronSchedule: firstEvent.details.cronSchedule,
     isWorkflowRunning,
     parentWorkflowRoute,
     result,

diff --git a/client/routes/workflow/summary.vue b/client/routes/workflow/summary.vue
@@ -43,6 +43,7 @@ export default {
     'input',
     'isWorkflowRunning',
     'parentWorkflowRoute',
+    'cronSchedule',
     'result',
     'runId',
     'timeFormat',
@@ -250,6 +251,10 @@ export default {
           </router-link>
         </dd>
       </div>
+      <div class="cron-schedule" v-if="cronSchedule">
+        <dt>Cron Schedule</dt>
+        <dd>{{ cronSchedule }}</dd>
+      </div>
       <div class="task-list">
         <dt>Task List</dt>
         <dd>
@@ -318,7 +323,7 @@ section.workflow-summary
     margin-bottom 1em
     dt
       padding 0 4px
-  .run-id, .task-list, .workflow-id, .workflow-name
+  .run-id, .task-list, .workflow-id, .workflow-name, .cron-schedule
     dd
       font-weight 300
       font-family monospace-font-family

diff --git a/client/test/fixtures.js b/client/test/fixtures.js
@@ -123,6 +123,7 @@ export default {
         eventType: 'WorkflowExecutionStarted',
         eventId: 1,
         details: {
+          cronSchedule: '30 * * * *',
           workflowType: {
             name: 'email-daily-summaries',
           },

diff --git a/client/test/workflow.test.js b/client/test/workflow.test.js
@@ -124,6 +124,10 @@ describe('Workflow', () => {
 
       summaryEl.should.not.have.descendant('.parent-workflow');
 
+      summaryEl
+        .querySelector('.cron-schedule dd')
+        .should.have.text('30 * * * *');
+
       summaryEl
         .querySelector('.workflow-status dd')
         .should.contain.text('running');
@@ -869,6 +873,7 @@ describe('Workflow', () => {
         startDetails
           .textNodes('dl.details dt')
           .should.deep.equal([
+            'cronSchedule',
             'workflowType.name',
             'taskList.name',
             'input',
@@ -878,6 +883,7 @@ describe('Workflow', () => {
         startDetails
           .textNodes('dl.details dd')
           .should.deep.equal([
+            '30 * * * *',
             'email-daily-summaries',
             'ci-task-queue',
             inputPreText,