Merged
Conversation
converts baseui codebase to typescript
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c2e3385:
|
tajo
approved these changes
Jul 20, 2022
Deploying with
|
| Latest commit: |
c2e3385
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cb703165.baseweb.pages.dev |
| Branch Preview URL: | https://chasestarr-patch-36.baseweb.pages.dev |
andriuss
pushed a commit
to andriuss/baseweb
that referenced
this pull request
Aug 2, 2022
converts baseui codebase to typescript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This major release of baseui includes no runtime changes to the library, but does include breaking typescript updates. If your application does not use TS there should be no changes.
Many typescript types have been updated to drop the
Tsuffix soPropsTis nowPropsin most instances. We've included backwards compatible aliases for t-suffixed types and those will be removed in a future major release. The main backwards incompatible change of note is when using thestyledfunction and provide generic parameters. The params order is reversed from the previous release to align closer with styletron.Please file issues if any type errors are found.
Scope
Major: Breaking change