Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Error Prone dependence compileOnly #50

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Conversation

msridhar
Copy link
Collaborator

Whenever NullAway runs, it must be loaded via Error Prone. Hence, I believe that the Error Prone Check APIs should always be available. Making the errorProneCheckApi a compileOnly dependence should reduce the size of the annotation processor classpath in some cases, which could speed up builds and avoid some incompatibilities like in #48.

@msridhar msridhar requested a review from kageiit October 30, 2017 17:30
@msridhar msridhar merged commit 4ded11c into master Oct 30, 2017
@msridhar msridhar deleted the ms-provided-dep branch October 30, 2017 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants